Skip to content

[ci] fix pypi publishing trigger #1444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kevinjqliu
Copy link
Contributor

@kevinjqliu kevinjqliu commented Jun 15, 2025

Which issue does this PR close?

  • Closes #.

What changes are included in this PR?

Follow up to #1379. This PR changes the pypi publishing step to trigger on previous workflow's successful run

Also see #1325 (comment)

Are these changes tested?

yes, tested the new logic

if: ${{ !contains(github.event.workflow_run.head_branch, '-') || github.event_name == 'workflow_dispatch' }}

by pushing a new tag to my fork and checking the github workflow run

@kevinjqliu kevinjqliu requested a review from liurenjie1024 June 15, 2025 01:29
@kevinjqliu kevinjqliu marked this pull request as draft June 15, 2025 02:04
@kevinjqliu kevinjqliu force-pushed the kevinjqliu/fix-pypi-publishing-trigger branch from 3fdcddc to 8a41302 Compare June 15, 2025 02:50
@kevinjqliu kevinjqliu marked this pull request as ready for review June 15, 2025 02:55
Copy link
Contributor

@liurenjie1024 liurenjie1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kevinjqliu for this pr, LGTM!

@liurenjie1024 liurenjie1024 merged commit c3a46b0 into apache:main Jun 16, 2025
26 of 27 checks passed
@kevinjqliu kevinjqliu deleted the kevinjqliu/fix-pypi-publishing-trigger branch June 16, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants