Add how to verify release doc #1426
Conversation
liurenjie1024
requested review from
sdd,
Xuanwo and
Fokko
and removed request for
sdd
| ```bash | ||
| curl https://downloads.apache.org/iceberg/KEYS -o KEYS | ||
| gpg --import KEYS | ||
| ``` |
There was a problem hiding this comment.
We can also include a section to download the release candidate and include the svn co command
There was a problem hiding this comment.
The link to artifacts will usually be included in the email voting for release, also user should not try to use svn co to download them. They should just use direct link. So I don't think we need to add them in the doc.
There was a problem hiding this comment.
ohh interesting, usually I follow the pyiceberg release docs since their documentation used to be the easiest to follow, but I just noticed that iceberg docs don't have this either
|
Kindly ping @Fokko @Xuanwo @sdd @kevinjqliu to take a look |
There was a problem hiding this comment.
LGTM, this follows pyiceberg's "verify a release" doc
Added a few nit comments
There was a problem hiding this comment.
nit: is this related to the PR?
| @@ -202,6 +202,35 @@ please cancel the release for the current `release_version`, | |||
| _increase th RC counting_ and re-initiate a release with the new `release_version`. | |||
| And remember to delete the wrong artifacts from the SVN dist repo. | |||
|
|
|||
| ## How to verify a release | |||
There was a problem hiding this comment.
nit: move this after the "Voting" section below, which sends out the email to vote for RC
| @@ -202,6 +202,35 @@ please cancel the release for the current `release_version`, | |||
| _increase th RC counting_ and re-initiate a release with the new `release_version`. | |||
| And remember to delete the wrong artifacts from the SVN dist repo. | |||
|
|
|||
| ## How to verify a release | |||
There was a problem hiding this comment.
lets add a link to this new section to the RC vote email too. the current instruction in the email is outdated
iceberg-rust/website/src/release.md
Lines 262 to 264 in bcd1033
maybe we can remove scripts/verify.py too
Which issue does this PR close?
What changes are included in this PR?
Add doc about how to verify release
Are these changes tested?
No.