test: that exception is thrown when malformed union is used #13888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonvex
changed the title
yihua
reviewed
Sep 12, 2025
Comment on lines
+941
to
+943
| Schema unionSchema = Schema.createUnion(Arrays.asList(Schema.create(Schema.Type.STRING), Schema.create(Schema.Type.DOUBLE))); | ||
| assertThrows(HoodieAvroSchemaException.class, | ||
| () -> HoodieAvroUtils.hasSmallPrecisionDecimalField(unionSchema)); |
There was a problem hiding this comment.
Is there a valid case that the UNION has two non-null types and NULL?
There was a problem hiding this comment.
In that case, the fix is not strictly correct?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
#13885 this needs a test
Impact
unit test for avro union extraction
Risk level (write none, low medium or high below)
none
Documentation Update
N/A
Contributor's checklist