HTTPCLIENT-2381 Enable automatic mapping #680
Conversation
arturobernalg
force-pushed
the
HTTPCLIENT-2381
branch
2 times, most recently
from
0f8cc97 to
537d126
Compare
httpclient5/src/main/java/org/apache/hc/client5/http/impl/classic/HttpClientBuilder.java
Show resolved
Hide resolved
arturobernalg
force-pushed
the
HTTPCLIENT-2381
branch
2 times, most recently
from
77210eb to
1fa05b7
Compare
…Y environment variables to standard JDK proxy system properties via new EnvironmentProxyConfigurer and make HttpClientBuilder use it by default
arturobernalg
force-pushed
the
HTTPCLIENT-2381
branch
from
d67f173 to
77c3f08
Compare
There was a problem hiding this comment.
@arturobernalg You should also add a similar option to HttpAsyncClientBuilder.
Please also invite the original reporter to take a look at the proposed fix. From I understand (but I can well be wrong) the reporter actually wants us to read system properties by default instead of opt-in. I am not sure this change-set is going to be enough.
|
@arturobernalg Actually I think the fix is misplaced. This logic should go into |
arturobernalg
force-pushed
the
HTTPCLIENT-2381
branch
from
b6335da to
c5e7684
Compare
| @@ -237,6 +237,9 @@ private ExecInterceptorEntry( | |||
|
|
|||
| private List<Closeable> closeables; | |||
|
|
|||
| private boolean applyEnvProxy; | |||
There was a problem hiding this comment.
@arturobernalg This should no longer be necessary, should it?
There was a problem hiding this comment.
@arturobernalg This should no longer be necessary, should it?
done
…r HTTP(S)_PROXY / NO_PROXY directly without altering JVM system properties
arturobernalg
force-pushed
the
HTTPCLIENT-2381
branch
from
765a1b0 to
b38a7b3
Compare
…roxySelector first, then HTTP(S)_PROXY/NO_PROXY). Add disableProxyAutodetection() to preserve legacy behavior.
arturobernalg
force-pushed
the
HTTPCLIENT-2381
branch
from
967769e to
a7030db
Compare
Enable env-proxy support ([HTTPCLIENT-2381](Enable env-proxy support (HTTPCLIENT-2381) – add EnvironmentProxyConfigurer, wire it into HttpClientBuilder, revert extra fallbacks, and introduce JUnit test (System-Lambda) with dep-management cleanup.)) – add
EnvironmentProxyConfigurer, wire it intoHttpClientBuilder, revert extra fallbacks, and introduce JUnit test (System-Lambda) with dep-management cleanup.