HIVE-29291: Use minHistoryWriteId by default #6154
Open
+55
−192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asf-ci-hive
added
tests pending
tests unstable
and removed
tests pending
tests unstable
labels
deniskuzZ
force-pushed
the
HIVE-26704
branch
2 times, most recently
from
140f810 to
15c61e6
Compare
asf-ci-hive
added
tests pending
tests unstable
and removed
tests unstable
tests pending
labels
deniskuzZ
changed the title
|
deniskuzZ
commented
Oct 27, 2025
| } | ||
| }); | ||
|
|
||
| Long minTxnId = jdbcResource.execute(new MinUncommittedTxnIdHandler()); |
There was a problem hiding this comment.
existing MinUncommittedTxnIdHandler wasn't used for unknown reason
deniskuzZ
commented
Oct 27, 2025
| if (txnType == TxnType.SOFT_DELETE || txnType == TxnType.COMPACTION) { | ||
| new AcquireTxnLockFunction(false).execute(jdbcResource); | ||
| if (!ConfVars.useMinHistoryWriteId()) { | ||
| new AcquireTxnLockFunction(false).execute(jdbcResource); |
There was a problem hiding this comment.
nextTxnId hwm is not used with MinHistoryWriteId, so no need to lock in oder to get accurate value
deniskuzZ
commented
Oct 27, 2025
| "FROM \"TXN_COMPONENTS\" WHERE \"TC_TXNID\"= :txnId AND \"TC_OPERATION_TYPE\" <> :type"), | ||
| writeSetInsertSql + (ConfVars.useMinHistoryLevel() ? conflictSQLSuffix : | ||
| "FROM \"TXN_COMPONENTS\" WHERE \"TC_TXNID\"= :txnId" + ( | ||
| (txnType != TxnType.REBALANCE_COMPACTION) ? "" : " AND \"TC_OPERATION_TYPE\" <> :type")), |
There was a problem hiding this comment.
REBALANCE_COMPACTION uses UPDATE operation semantic with EXCL_WRITE
deniskuzZ
commented
Oct 27, 2025
| queryBatch.add("DELETE FROM \"MATERIALIZATION_REBUILD_LOCKS\" WHERE \"MRL_TXN_ID\" = " + txnid); | ||
| } | ||
| if (txnType == TxnType.SOFT_DELETE || txnType == TxnType.COMPACTION) { | ||
| if (txnType == TxnType.SOFT_DELETE || MetaStoreServerUtils.isCompactionTxn(txnType)) { |
There was a problem hiding this comment.
no idea why REBALANCE_COMPACTION was excluded, looks like a bug
deniskuzZ
commented
Oct 27, 2025
| " \"CUR\".\"TC_PARTITION\" IS NULL) " + | ||
| // txns overlap | ||
| " WHERE \"CUR\".\"TC_TXNID\" <= \"COMMITTED\".\"WS_COMMIT_ID\""; | ||
| " WHERE \"CUR\".\"TC_TXNID\" <= \"COMMITTED\".\"WS_COMMIT_ID\"" + |
There was a problem hiding this comment.
just moved the predicate under the WHERE clause
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Use minHistoryWriteId by default
Why are the changes needed?
Overcomes scalability constraints imposed by global min open txn concept
Does this PR introduce any user-facing change?
No
How was this patch tested?
Jenkins