YARN-11823: add new endpoints for getting jstacks of application and nodes #7726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hean-Chhinling
force-pushed
the
trunk_YARN-11823
branch
from
8ec513c to
80814ff
Compare
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
K0K0V0K
reviewed
Jun 5, 2025
| @@ -271,6 +273,35 @@ public ContainerInfo getNodeContainer(@javax.ws.rs.core.Context | |||
|
|
|||
| } | |||
|
|
|||
| @GET | |||
| @Path("/jstack") | |||
There was a problem hiding this comment.
I think this can be a bit misleading name cause we already have a /stacks API for jstack
There was a problem hiding this comment.
Also how those it different from /stacks ?
| public Response getNodeJStack() { | ||
| try { | ||
| return Response.status(Status.OK) | ||
| .entity(DiagnosticJStackService.collectNodeJStack()) // Make sure the NodeManager have python3 install |
There was a problem hiding this comment.
What will happen if py3 is not present?
| private static final String PYTHON_COMMAND = "python3"; | ||
| private static String scriptLocation = null; | ||
|
|
||
| static { |
There was a problem hiding this comment.
This static block will block the NM to start up, till it is not done
| } | ||
| } | ||
|
|
||
| public static String collectNodeJStack() |
There was a problem hiding this comment.
First i read NodeJS, can we use other name here?
|
|
||
| protected static ProcessBuilder createProcessBuilder() { | ||
| List<String> commandList = | ||
| new ArrayList<>(Arrays.asList(PYTHON_COMMAND, scriptLocation)); |
|
|
||
| NUMBER_OF_JSTACK = 3 | ||
|
|
||
| def get_nodemanager_pid(): |
There was a problem hiding this comment.
I beleive from security perspective, these should not be available in REST API in case of not secure cluster, and we should do authorisation in secured clusters.
K0K0V0K
reviewed
Jun 5, 2025
| import subprocess | ||
| import sys | ||
|
|
||
| NUMBER_OF_JSTACK = 3 |
There was a problem hiding this comment.
This can be path throw REST
| @@ -271,6 +273,35 @@ public ContainerInfo getNodeContainer(@javax.ws.rs.core.Context | |||
|
|
|||
| } | |||
|
|
|||
| @GET | |||
| @Path("/jstack") | |||
There was a problem hiding this comment.
Also how those it different from /stacks ?
|
💔 -1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
How was this patch tested?
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?