-
Notifications
You must be signed in to change notification settings - Fork 13.8k
[FLINK-38338][runtime] Introduce the abstraction to describe a rescale event. #26981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,6 +21,7 @@ | |
import org.apache.flink.api.common.JobID; | ||
import org.apache.flink.api.common.JobStatus; | ||
import org.apache.flink.runtime.executiongraph.ArchivedExecutionGraph; | ||
import org.apache.flink.runtime.scheduler.adaptive.timeline.Durable; | ||
|
||
import org.slf4j.Logger; | ||
|
||
|
@@ -34,13 +35,21 @@ class Finished implements State { | |
|
||
private final Logger logger; | ||
|
||
private final Durable durable; | ||
|
||
Finished(Context context, ArchivedExecutionGraph archivedExecutionGraph, Logger logger) { | ||
this.archivedExecutionGraph = archivedExecutionGraph; | ||
this.logger = logger; | ||
this.durable = new Durable(); | ||
|
||
context.onFinished(archivedExecutionGraph); | ||
} | ||
|
||
@Override | ||
public Durable getDurable() { | ||
return durable; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we not just have:
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks @davidradl for your comments. Please let me have a try on clarifying it: |
||
} | ||
|
||
@Override | ||
public void cancel() {} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add the slotSharingGroupName; to the toString(). We should have a hashcode for this object in including slotSharingGroupName.