- 
                Notifications
    
You must be signed in to change notification settings  - Fork 1.7k
 
Bump MSRV to 1.88.0 #18403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump MSRV to 1.88.0 #18403
Conversation
Update Minimum Supported Rust Version from 1.87.0 to 1.88.0 per MSRV policy. Rust 1.91.0 was released, which allows us to upgrade from 1.87.0 to 1.88.0 following our policy of supporting the last 4 stable Rust minor versions. Closes apache#18395
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @harshasiddartha
| 
               | 
          ||
| [`1.87.0`]: https://releases.rs/docs/1.87.0/ | ||
| 
               | 
          ||
| ### `MSRV` updated to 1.88.0 | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@harshasiddartha -- can you please consolidate this entry with the one above (there is no need to say we updated the MSRV from 1.87 and to 1.88)?
Combine the separate 1.87.0 and 1.88.0 MSRV entries into a single entry as requested in review.
| 
           Thanks for the review @alamb! I've consolidated the MSRV entries into a single entry as requested. The documentation now only mentions the update to 1.88.0 without referencing the previous version.  | 
    
| 
           Hi @alamb, I've already consolidated the MSRV entries in commit 1caee69. The documentation now has a single entry for "MSRV updated to 1.88.0" without any reference to version 1.87.0. The old 1.87.0 entry has been completely removed and replaced with the 1.88.0 entry. Please let me know if you're still seeing any references to 1.87.0 in the PR diff view - I can double-check if needed.  | 
    
| 
           @alamb can you review and merge my pr  | 
    
| 
           Looks good to me now -- thank you @harshasiddartha and @Jefffrey  | 
    
## Description This PR bumps the Minimum Supported Rust Version (MSRV) from 1.87.0 to 1.88.0 per our MSRV policy. Rust 1.91.0 was released today: https://blog.rust-lang.org/2025/10/30/Rust-1.91.0/ Per our MSRV policy we can now upgrade from 1.87.0 to 1.88.0. The policy states that DataFusion supports the last 4 stable Rust minor versions released and any such versions released within the last 4 months. ## Changes - Updated `rust-version` in `Cargo.toml` from `1.87.0` to `1.88.0` - Added upgrade note in `docs/source/library-user-guide/upgrading.md` ## Testing - ✅ Verified the code compiles with Rust 1.90.0 (newer than MSRV) - ✅ All workspace crates compile successfully ## Related Closes apache#18395 ## Notes This change enables the use of Rust 1.88.0 features, including let chains, which are now available for use in the codebase.
Description
This PR bumps the Minimum Supported Rust Version (MSRV) from 1.87.0 to 1.88.0 per our MSRV policy.
Rust 1.91.0 was released today: https://blog.rust-lang.org/2025/10/30/Rust-1.91.0/
Per our MSRV policy we can now upgrade from 1.87.0 to 1.88.0. The policy states that DataFusion supports the last 4 stable Rust minor versions released and any such versions released within the last 4 months.
Changes
rust-versioninCargo.tomlfrom1.87.0to1.88.0docs/source/library-user-guide/upgrading.mdTesting
Related
Closes #18395
Notes
This change enables the use of Rust 1.88.0 features, including let chains, which are now available for use in the codebase.