Skip to content

Conversation

@harshasiddartha
Copy link
Contributor

Description

This PR bumps the Minimum Supported Rust Version (MSRV) from 1.87.0 to 1.88.0 per our MSRV policy.

Rust 1.91.0 was released today: https://blog.rust-lang.org/2025/10/30/Rust-1.91.0/

Per our MSRV policy we can now upgrade from 1.87.0 to 1.88.0. The policy states that DataFusion supports the last 4 stable Rust minor versions released and any such versions released within the last 4 months.

Changes

  • Updated rust-version in Cargo.toml from 1.87.0 to 1.88.0
  • Added upgrade note in docs/source/library-user-guide/upgrading.md

Testing

  • ✅ Verified the code compiles with Rust 1.90.0 (newer than MSRV)
  • ✅ All workspace crates compile successfully

Related

Closes #18395

Notes

This change enables the use of Rust 1.88.0 features, including let chains, which are now available for use in the codebase.

Update Minimum Supported Rust Version from 1.87.0 to 1.88.0 per MSRV policy.

Rust 1.91.0 was released, which allows us to upgrade from 1.87.0 to 1.88.0
following our policy of supporting the last 4 stable Rust minor versions.

Closes apache#18395
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 31, 2025
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @harshasiddartha


[`1.87.0`]: https://releases.rs/docs/1.87.0/

### `MSRV` updated to 1.88.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harshasiddartha -- can you please consolidate this entry with the one above (there is no need to say we updated the MSRV from 1.87 and to 1.88)?

Combine the separate 1.87.0 and 1.88.0 MSRV entries into a single
entry as requested in review.
@harshasiddartha
Copy link
Contributor Author

Thanks for the review @alamb! I've consolidated the MSRV entries into a single entry as requested. The documentation now only mentions the update to 1.88.0 without referencing the previous version.

@harshasiddartha
Copy link
Contributor Author

Hi @alamb, I've already consolidated the MSRV entries in commit 1caee69. The documentation now has a single entry for "MSRV updated to 1.88.0" without any reference to version 1.87.0. The old 1.87.0 entry has been completely removed and replaced with the 1.88.0 entry. Please let me know if you're still seeing any references to 1.87.0 in the PR diff view - I can double-check if needed.

@harshasiddartha harshasiddartha requested a review from alamb October 31, 2025 20:53
@harshasiddartha
Copy link
Contributor Author

@alamb can you review and merge my pr

@alamb
Copy link
Contributor

alamb commented Nov 1, 2025

Looks good to me now -- thank you @harshasiddartha and @Jefffrey

@alamb alamb added this pull request to the merge queue Nov 1, 2025
Merged via the queue into apache:main with commit e969500 Nov 1, 2025
32 checks passed
tobixdev pushed a commit to tobixdev/datafusion that referenced this pull request Nov 2, 2025
## Description

This PR bumps the Minimum Supported Rust Version (MSRV) from 1.87.0 to
1.88.0 per our MSRV policy.

Rust 1.91.0 was released today:
https://blog.rust-lang.org/2025/10/30/Rust-1.91.0/

Per our MSRV policy we can now upgrade from 1.87.0 to 1.88.0. The policy
states that DataFusion supports the last 4 stable Rust minor versions
released and any such versions released within the last 4 months.

## Changes

- Updated `rust-version` in `Cargo.toml` from `1.87.0` to `1.88.0`
- Added upgrade note in `docs/source/library-user-guide/upgrading.md`

## Testing

- ✅ Verified the code compiles with Rust 1.90.0 (newer than MSRV)
- ✅ All workspace crates compile successfully

## Related

Closes apache#18395

## Notes

This change enables the use of Rust 1.88.0 features, including let
chains, which are now available for use in the codebase.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bump MSRV to 1.88.0

3 participants