fix: ignore non-existent columns when adding filter equivalence info in FileScanConfig
#17546
+20
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #17511
Rationale for this change
When building equal conditions in a data source node, we want to ignore any stale references to columns that may have been swapped out (e.g. from
try_swapping_with_projection
).The current code reassigns predicate columns from the filter to refer to the corresponding ones in the updated schema. However, it only ignores non-projected columns.
reassign_predicate_columns
builds an invalid column expression (with indexusize::MAX
) if the column is not projected in the current schema. We don't want to refer to this in the equal conditions we build.What changes are included in this PR?
Ignores any binary expressions that reference non-existent columns in the current schema (e.g. due to unnecessary projections being removed).
Are these changes tested?
Are there any user-facing changes?
N/A