Introduce wildcard const for FixedSizeBinary type signature #17531
Conversation
| /// valid length. It exists to avoid the need to enumerate all possible fixed size binary lengths. | ||
| /// | ||
| /// The value is offset by 1 to make it distinct from [`FIXED_SIZE_LIST_WILDCARD`]. | ||
| pub const FIXED_SIZE_BINARY_WILDCARD: i32 = i32::MIN + 1; |
There was a problem hiding this comment.
Just in case someone puts FIXED_SIZE_LIST_WILDCARD when they meant FIXED_SIZE_BINARY_WILDCARD, as otherwise they would be interchangeable
| /// This is used where a function can accept a fixed size binary type with any | ||
| /// valid length. It exists to avoid the need to enumerate all possible fixed size binary lengths. | ||
| /// | ||
| /// The value is offset by 1 to make it distinct from [`FIXED_SIZE_LIST_WILDCARD`]. |
| @@ -913,6 +916,10 @@ fn coerced_from<'a>( | |||
| Some(_) => Some(FixedSizeList(Arc::clone(f_into), *size_from)), | |||
| _ => None, | |||
| }, | |||
| // should be able to coerce wildcard fixed size binary to non wildcard fixed size binary | |||
| (FixedSizeBinary(FIXED_SIZE_BINARY_WILDCARD), FixedSizeBinary(size_from)) => { | |||
There was a problem hiding this comment.
technically speaking, FixedSizeBinary(-2147483647) is not a valid type, so it's not meaningful to define a coercion between it and any other type. I can see how it may be useful in case of function signatures though. What we actually want is generic signatures in functions. i.e. a signature that is not a type itself, but matches a type.
| Binary, | ||
| BinaryView, | ||
| LargeBinary, | ||
| FixedSizeBinary(FIXED_SIZE_BINARY_WILDCARD), |
There was a problem hiding this comment.
Rather than use this invalid type hack, i'd recommend implementing this for now as a "user defined signature"
long term solution is to have Signature::uniform accept generic types (type patterns).
Do we have any tracking issues for these atm? |
|
I realized we may get away without introducing a generic type concept. cc @jayzhan211 |
Let me take a look 👍 |
Which issue does this PR close?
Rationale for this change
Currently not able to easily represent arbitrary sized
FixedSizeBinarys in type signature API.What changes are included in this PR?
Introduce new
FIXED_SIZE_BINARY_WILDCARDconst that allows specifying type signatures which accept arbitrarily sized fixed size binary, similar toFIXED_SIZE_LIST_WILDCARD. Also modifybitmap_countsignature to use this new signature.Are these changes tested?
Are there any user-facing changes?