fix: Preserves field metadata when creating logical plan for VALUES expression #17525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
Kontinuation
force-pushed
the
fix-issue-17425
branch
from
4de7c9f to
ecb5971
Compare
|
CC @paleolimbot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
The metadata of fields created by
VALUESSQL expression were lost during the creation ofLogicalPlan::Valueslogical plan node. This patch tries to preserve the field metadata.What changes are included in this PR?
This patch takes the metadata of fields in
VALUESexpression into consideration. The schema ofVALUESexpression will contain field with proper metadata.Are these changes tested?
user_defined_scalar_functionstestAre there any user-facing changes?
No public API changes.