Switch from xz2 to liblzma to reduce duplicate dependencies #17509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
|
btw there is a bunch of work upstream to make an |
|
is this "fixes #15342" ? |
|
Thank you @findepi . I should have searched the issues to find it reported. The upstream PR is merged, so once it's next release comes out I can update this PR and mark it ready. |
|
It looks like upstream is on a 2 month release cadence, so we'll see if that lands first or the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #15342
Rationale for this change
Reduces the duplicate dependencies.
We currently depend on bzip2 in two different ways. In attempting to reduce this, I needed to update
async-compressionwhich caused two different libraries to link to the system lzma library. This is not allowed in rust.This PR updates avro-rs, but we cannot merge this PR until that crate merges apache/avro-rs#284 and we remove the crates.io patch this PR contains.
What changes are included in this PR?
Update avro-rs and switch from the unmaintained xz2 crate to liblzma.
Are these changes tested?
Unit tests.
Are there any user-facing changes?
None. This is simply a dependency update to a more recent crate.