Skip to content

chore: Use SpiderMonkey v128 as default version #5624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: Use SpiderMonkey v128 as default version #5624

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion configure
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ run_erlang() {

COUCHDB_USER="$(whoami 2>/dev/null || echo couchdb)"
JS_ENGINE=${JS_ENGINE:-"spidermonkey"}
SM_VSN=${SM_VSN:-"91"}
SM_VSN=${SM_VSN:-"128"}
CLOUSEAU_MTH=${CLOUSEAU_MTH:-"dist"}
CLOUSEAU_URI=${CLOUSEAU_URI:-"https://github.com/cloudant-labs/clouseau/releases/download/%s/clouseau-%s-dist.zip"}
CLOUSEAU_VSN=${CLOUSEAU_VSN:-"2.25.0"}
Expand Down
4 changes: 2 additions & 2 deletions configure.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
-WithClouseau build the Clouseau search module (default false)
-SkipDeps do not update Erlang dependencies (default false)
-CouchDBUser USER set the username to run as (defaults to current user)
-SpiderMonkeyVersion VSN select the version of SpiderMonkey to use (default 91)
-SpiderMonkeyVersion VSN select the version of SpiderMonkey to use (default 128)
-JSEngine ENGINE select JS engine to use (spidermonkey or quickjs) (default spidermonkey)
-ClouseauVersion VSN select the version of Clouseau to use (default 2.25.0)
-ClouseauMethod MTH method for Clouseau to deploy: git or dist (default dist)
Expand Down Expand Up @@ -60,7 +60,7 @@ Param(
[ValidateNotNullOrEmpty()]
[string]$CouchDBUser = [Environment]::UserName, # set the username to run as (defaults to current user)
[ValidateNotNullOrEmpty()]
[string]$SpiderMonkeyVersion = "91", # select the version of SpiderMonkey to use (default 91)
[string]$SpiderMonkeyVersion = "128", # select the version of SpiderMonkey to use (default 91)
[ValidateNotNullOrEmpty()]
[string]$JSEngine = "spidermonkey", # select the JS engine (spidermonkey | quickjs) to use (default spidermonkey)
[ValidateNotNullOrEmpty()]
Expand Down
4 changes: 2 additions & 2 deletions src/couch/rebar.config.script
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,12 +98,12 @@ SMVsn = case lists:keyfind(spidermonkey_version, 1, CouchConfig) of
{_, "128"} ->
"128";
undefined ->
"91";
"128";
{_, Unsupported} ->
io:format(standard_error, "Unsupported SpiderMonkey version: ~s~n", [Unsupported]),
erlang:halt(1);
false ->
"91"
"128"
end.

ConfigH = [
Expand Down