Skip to content

Update counter, condition and autoscale policies type in responses #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update counter, condition and autoscale policies type in responses #119

wants to merge 1 commit into from

Conversation

Pearl1594
Copy link
Contributor

Fix incorrect datatype for objects of autoscale vm policy and group responses.

@Pearl1594 Pearl1594 marked this pull request as ready for review September 2, 2025 14:58
@Pearl1594 Pearl1594 mentioned this pull request Sep 2, 2025
Open
weizhouapache
weizhouapache approved these changes Sep 3, 2025
View reviewed changes
Copy link
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@Pearl1594 Pearl1594 force-pushed the fix-counter-response-object branch from 2ea307d to fb27f75 Compare September 3, 2025 13:18
DaanHoogland
DaanHoogland approved these changes Sep 8, 2025
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm, do we need to / can we add any testing for this?

vishesh92
vishesh92 approved these changes Sep 8, 2025
View reviewed changes
Copy link
Member

@vishesh92 vishesh92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@vishesh92 vishesh92 vishesh92 approved these changes

@weizhouapache weizhouapache weizhouapache approved these changes

@shwstppr shwstppr Awaiting requested review from shwstppr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Pearl1594 @DaanHoogland @vishesh92 @weizhouapache