Bump logback to most recent Java8-compatible version #2051
Conversation
…org.slf4j.spi.LoggingEventAware. https://logback.qos.ch/setup.html has some more docs on this (at least as of this writing)
| @@ -65,7 +65,7 @@ | |||
| --> | |||
| <tinkerpop.version>3.5.6</tinkerpop.version> | |||
| <!-- when changing version also update version in LICENSE_binary --> | |||
| <slf4j.version>1.7.26</slf4j.version> | |||
| <slf4j.version>2.0.16</slf4j.version> | |||
There was a problem hiding this comment.
Have to bump slf4j version as well here in order to address compile errors re: unable to find org.slf4j.spi.LoggingEvent once we moved to logback 1.3.x. Per the discussion here it looks like slf4j 2.x is required for logback 1.3.x.
|
Bah, it's even worse than I originally thought. slf4j 2.x includes some new OSGi directives which appear to break our OSGi tests. I'm trying to find a fix via this project but haven't had any luck so far. |
This technique was discovered and implemented by Lukasz Antoniak.
| mavenBundle("org.ow2.asm", "asm-commons").version("9.6"), | ||
| mavenBundle("org.ow2.asm", "asm-util").version("9.6"), | ||
| mavenBundle("org.ow2.asm", "asm-tree").version("9.6"), | ||
| mavenBundle("org.ow2.asm", "asm-analysis").version("9.6"), |
There was a problem hiding this comment.
This code was discovered and implemented independently by @lukasz-antoniak . Huge hat tip to him for his contribution here!
|
Jenkins run confirms that failures in OSGi tests are resolved by the fix provided here by @lukasz-antoniak. At this point I'm calling this one good. |
Aiming for a more modern version of #1901