-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Metastore example #35722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Metastore example #35722
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @tarun-google, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
I've added a new example demonstrating how to perform a batch write operation to an Iceberg table, leveraging the BigQuery Metastore catalog within an Apache Beam pipeline. This example showcases reading data from a public BigQuery dataset, processing it, and then writing the aggregated results to a new Iceberg table managed by BigQuery Metastore.
Highlights
- New Iceberg Batch Write Example: I've introduced IcebergBatchWriteExample.java, a new Java example that illustrates a complete data pipeline.
- BigQuery Metastore Integration: This example specifically highlights the integration with BigQuery Metastore for managing Iceberg tables.
- Dependency Update: I've updated examples/java/build.gradle to include the necessary iceberg:bqms runtime dependency, enabling the BigQuery Metastore functionality.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new example for batch writing to an Iceberg table using the BigQuery Metastore. The changes are well-contained, adding the necessary dependency and the example code. My review includes suggestions to fix a Javadoc formatting issue that could break the build, remove a potentially confusing and outdated date from a comment, and refactor a complex lambda to improve code readability and maintainability.
Adding Example for Batch Write with Iceberg BigQuery Metastore. Sample run for the pipeline is attached below
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.