ATLAS-5059: add support for rdbms backend and audit repository #389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mneethiraj
requested review from
rameeshm,
ashutoshm,
sarathsubramanian,
chaitalicod,
pinal-shah,
rkundam and
Copilot
There was a problem hiding this comment.
Pull Request Overview
This pull request adds support for a new RDBMS backend using PostgreSQL for JanusGraph and the entity-audit repository, replacing the existing HBase configuration.
- Introduces new modules (e.g. DaoManager, RdbmsStoreManager, RdbmsStore, etc.) for RDBMS support.
- Integrates changes in AtlasJanusGraphDatabase via reflection to inject the new store manager and updates docker configuration and scripts to enable Postgres backend.
Reviewed Changes
Copilot reviewed 20 out of 44 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| graphdb/janusgraph-rdbms/src/main/java/org/janusgraph/diskstorage/rdbms/dao/DaoManager.java | Initializes the JPA layer for RDBMS; iterates persistence providers. |
| graphdb/janusgraph-rdbms/src/main/java/org/janusgraph/diskstorage/rdbms/RdbmsStore.java | Implements the RDBMS-backed KeyColumnValue store with store creation and key mapping logic. |
| graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphDatabase.java | Injects RDBMS support into graphdb via reflection. |
| Docker and configuration files | Update docker-compose and shell scripts to support Postgres as backend. |
graphdb/janusgraph-rdbms/src/main/java/org/janusgraph/diskstorage/rdbms/dao/DaoManager.java
Outdated
Show resolved
Hide resolved
graphdb/janusgraph-rdbms/src/main/java/org/janusgraph/diskstorage/rdbms/RdbmsStore.java
Outdated
Show resolved
Hide resolved
graphdb/janusgraph-rdbms/src/main/java/org/janusgraph/diskstorage/rdbms/RdbmsStore.java
Outdated
Show resolved
Hide resolved
kumaab
reviewed
Jun 20, 2025
| @@ -50,9 +50,13 @@ Docker files in this folder create docker images and run them to build Apache At | |||
|
|
|||
| Time taken to complete the build might vary (upto an hour), depending on status of ${HOME}/.m2 directory cache. | |||
|
|
|||
| 6.2. Execute following command to install and start Atlas and dependent services (Solr, HBase, Kafka) in containers: | |||
| 6.2. To install and start Atlas using Postgres as backend store, execute following commands: | |||
| export ATLAS_BACKEND=postgres | |||
There was a problem hiding this comment.
Changes to .github/workflows/ci.yml would be required to incorporate the docker changes for CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
enhancements to support using Postgres as the backend store for JanusGraph and entity-audit, replacing HBase.
How was this patch tested?
Verified that Atlas: