GH-47941: [R] Fix codegen.R error from dplyr pipe to base pipe change #47985
+15
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
Component: R
awaiting committer review
thisisnic
commented
Oct 28, 2025
r/configure
Outdated
Comment on lines
86
to
89
| if ! ${R_HOME}/bin/Rscript data-raw/codegen.R; then | ||
| echo "*** ERROR: codegen.R failed" | ||
| exit 1 | ||
| fi |
There was a problem hiding this comment.
I was surprised codegen failing didn't cause the CI job to fail, but it'll just use the existing (possibly outdated) files, so now at least we should catch it.
github-actions
bot
added
awaiting changes
github-actions
bot
added
awaiting change review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Switching to base pipe means that we need to update some syntax in codegen.R otherwise it errors when run
What changes are included in this PR?
Factor out code into own function so can use base pipe
Are these changes tested?
No, though weird it didn't fail on CI - looking into this!
Are there any user-facing changes?
Nope