Skip to content

GH-47232: [Ruby] Suppress warnings in test with Ruby 3.5 #47233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2025

Conversation

kou
Copy link
Member

@kou kou commented Jul 30, 2025

Rationale for this change

ruby/red-arrow/test/test-buffer.rb:26: warning: ObjectSpace._id2ref is deprecated
ruby/red-arrow/test/test-ractor.rb:32: warning: Ractor#take was deprecated and use Ractor#value instead. This method will be removed after the end of Aug 2025

What changes are included in this PR?

  • Use ObjectSpace::WeakMap instead of ObjectSapce._id2ref
  • Use Ractor#value instead of Ractor#take

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

Copy link

⚠️ GitHub issue #47232 has been automatically assigned in GitHub to PR creator.

@kou kou force-pushed the ruby-test-warnings branch from 65de8ac to 5d6c501 Compare July 30, 2025 20:41
@kou
Copy link
Member Author

kou commented Aug 5, 2025

+1

@kou kou merged commit 5f4ba59 into apache:main Aug 5, 2025
9 checks passed
@kou kou deleted the ruby-test-warnings branch August 5, 2025 06:33
@kou kou removed the awaiting committer review Awaiting committer review label Aug 5, 2025
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 5f4ba59.

There weren't enough matching historic benchmark results to make a call on whether there were regressions.

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant