-
Notifications
You must be signed in to change notification settings - Fork 53
GH-759: Get length of byte[] in TryCopyLastError #760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to add a test?
The error message in CI doesn't seem to be related to my PR:
linkage: https://github.com/apache/arrow-java/actions/runs/15140171347/job/42594091462?pr=760 Do you have some suggestions? |
I'll try to add a test case in |
Could you open a separated issue for it? |
Do you need an integration test? IMO, you should be able to export a stream, then immediately import it, all within Java. |
issue: #767 |
Thanks. (We've fixed this problem in apache/arrow. Sorry for not sharing it here...) |
I add a unittest but I think it can't make sure |
This comment has been minimized.
This comment has been minimized.
Can't the test validate that the exception has the right error message after making it through the FFI boundary? |
What's Changed
Please fill in a description of the changes here.
We should get the length of byte[] by
GetArrayLength
but notstrlen
which may cause invalid memory access.Closes #759 .