Skip to content

Bug/scalability subsetting #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 40 commits into
base: main
Choose a base branch
from
Open

Conversation

HavierD
Copy link
Contributor

@HavierD HavierD commented Apr 9, 2025

No description provided.

@HavierD HavierD requested a review from Copilot April 9, 2025 06:50
@HavierD HavierD marked this pull request as draft April 9, 2025 06:50
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

data_access_service/utils/date_time_utils.py:21

  • [nitpick] Remove the extra space between the function name and the parenthesis for consistency with the other utility functions.
def get_first_day_of (date:datetime) -> datetime:

data_access_service/models/data_file_factory.py:37

  • [nitpick] Consider logging a more descriptive message instead of directly printing a boolean result to improve clarity.
self.log.info(sys.getsizeof(self.data_frame) > 512 * 1024 * 1024)

@HavierD HavierD requested a review from utas-raymondng April 9, 2025 07:12
@HavierD HavierD marked this pull request as ready for review April 24, 2025 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant