Skip to content

GO-5379 fix the undeletable space #2272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fat-fellow
Copy link
Contributor


  • I understand that contributing to this repository will require me to agree with the CLA

Description

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 README.md
  • 📓 tech-docs
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

Copy link

Testomat.io Report 🟢 SMOKE-TEST PASSED
Tests ✔️ 10 tests run
Summary 🟢 10 passed; 🟡 0 skipped
Duration 🕐 15 minutes, 18 seconds
Testomat.io Report 📊 Run #3b3e919a
Job 🗂️ Smoke Tests / smoke-test
Operating System 🖥️ Linux X64

✅ Passed Tests (10)

  • Revoking an invite link (3 minutes, 2 seconds)
  • User cancels their join request (1 minute, 23 seconds)
  • User deletes the space and rejoins later (1 minute, 35 seconds)
  • Owner changes the rights of a user from Viewer to Editor (1 minute, 44 seconds)
  • Owner approves a join request with Editor permissions (1 minute, 29 seconds)
  • Owner declines a join request (1 minute, 3 seconds)
  • Owner removes a participant from the space (1 minute, 18 seconds)
  • Owner deletes a space (1 minute, 19 seconds)
  • Owner approves leave request (1 minute, 19 seconds)
  • Sync on staging nodes (1 minute, 1 seconds)

Copy link

Previous Coverage 50.4% of statements
New Coverage 50.4% of statements
Patch Coverage 76.9% of changed statements (20/26)

Coverage provided by https://github.com/seriousben/go-patch-cover-action

@fat-fellow fat-fellow requested a review from mcrakhman March 28, 2025 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant