chore(security): Add trivy scanner for image vulnerabilities #915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📝 WalkthroughSummary by CodeRabbit
WalkthroughA new GitHub Actions workflow file has been added to automate vulnerability scanning of Docker images using Trivy. The workflow runs on manual dispatch, pull request events, and on a daily schedule, scanning both "latest" and "nightly" tagged images for vulnerabilities and failing if any CRITICAL severity issues are found (excluding unfixed vulnerabilities). Changes
Sequence Diagram(s)sequenceDiagram
participant GitHub Actions
participant Docker Registry
participant Trivy
GitHub Actions->>Docker Registry: Pull "latest" image
GitHub Actions->>Trivy: Run scan on "latest" image
Trivy-->>GitHub Actions: Return scan results
GitHub Actions->>Docker Registry: Pull "nightly" image
GitHub Actions->>Trivy: Run scan on "nightly" image
Trivy-->>GitHub Actions: Return scan results
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested reviewers
Note 🔌 MCP (Model Context Protocol) integration is now available in Early Access!Pro users can now connect to remote MCP servers under the Integrations page to get reviews and chat conversations that understand additional development context. 📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.github/workflows/trivy.yaml (1)
13-41: DRY up duplicate jobs with a matrix strategy
latest-scanandnightly-scanare identical except for the tag. Maintaining two copies increases maintenance overhead and risk of drift. A single matrix job keeps the file concise and easier to extend (e.g., addingstable).-jobs: - latest-scan: - name: Scan Latest Image tag - runs-on: ubuntu-latest - steps: - - name: Pull image - run: docker pull ghcr.io/antonbabenko/pre-commit-terraform:latest - - name: Run Trivy vulnerability scanner - uses: aquasecurity/trivy-action@dc5a429b52fcf669ce959baa2c2dd26090d2a6c4 # v0.32.0 - with: - image-ref: ghcr.io/antonbabenko/pre-commit-terraform:latest - exit-code: '1' - ignore-unfixed: true - - nightly-scan: - name: Scan Nightly Image tag - runs-on: ubuntu-latest - steps: - - name: Pull image - run: docker pull ghcr.io/antonbabenko/pre-commit-terraform:nightly - - name: Run Trivy vulnerability scanner - uses: aquasecurity/trivy-action@dc5a429b52fcf669ce959baa2c2dd26090d2a6c4 # v0.32.0 - with: - image-ref: ghcr.io/antonbabenko/pre-commit-terraform:nightly - exit-code: '1' - ignore-unfixed: true +jobs: + trivy-scan: + strategy: + matrix: + tag: [latest, nightly] + runs-on: ubuntu-latest + name: Scan ${{ matrix.tag }} image + steps: + - name: Pull image + run: docker pull ghcr.io/antonbabenko/pre-commit-terraform:${{ matrix.tag }} + - name: Run Trivy vulnerability scanner + uses: aquasecurity/trivy-action@dc5a429b52fcf669ce959baa2c2dd26090d2a6c4 # v0.32.0 + with: + image-ref: ghcr.io/antonbabenko/pre-commit-terraform:${{ matrix.tag }} + exit-code: '1' + ignore-unfixed: true(Nice-to-have; feel free to defer if keeping explicit jobs improves clarity.)
yermulnik
reviewed
Aug 7, 2025
There was a problem hiding this comment.
The rabbit's suggestion to use matrix looks relevant — is it plausible and feasible? #915 (review)
|
This PR has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this PR will be closed in 10 days |
github-actions
bot
added
the
stale
|
Terrascan will soon be not supported at all, and current issues will not be fixed 
Not sure what to do with this workflow |
github-actions
bot
removed
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Put an
xinto the box if that apply:Description of your changes
Add Tryvy security scanner to check most resent Docker image tags for known vulnerabilities