-
Notifications
You must be signed in to change notification settings - Fork 3.8k
[PlSql] Multiple grammar improvements #4640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This change also adjusts the behavior of inmemory_attributes so that the SQL can supply these attributes in any order, as allowed by the engine.
In Oracle 10g, supplemental logging was improved for logical replication to include the "UNIQUE INDEX" clause to log columns that are not declared as unique constraints, used by Streams and GoldenGate replication.
4143e25
to
93f3572
Compare
Hi @teverett I'm trying to understand the various failures, but it's not clear what is broken. When running the tests via Maven, everything passes. Any pointers on what I may have missed? |
The error is caused by time-outs on the network file transfers from Maven. There are a number of ways I could fix this:
The old Antlr Maven tester is old and hasn't been updated since 4.11.1 or 2. Plus, it does not test any targets except Java. My recommendation is to try making a change and pushing it around 6 am EDT. |
@kaby76 are you sure that's the case for all of them, e.g. ubuntu-latest Go
|
You're right. Not all of the problems were network timeouts. For CSharp, TypeScript, Python, and maybe others, you made the bool For Go, There's no "base class" initializers! To get around this mess, I had to implement a global, static struct. You'll have to initialize _isVersion11 to "true" in |
93f3572
to
88f3ab2
Compare
This PR includes a myriad of grammar improvements, separated by commit. Given that many of these may touch or adjust various similar files, it made more sense to put these into 1 PR where they can be reviewed by commit rather than multiple PRs that would require continuous rebases.