Fix typing_extensions import to avoid ModuleNotFoundError on Python 3.11+ #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SDK unconditionally imported `typing_extensions.NotRequired`, but `typing_extensions` is declared as a dependency only for Python < 3.11 in pyproject.toml. On Python 3.11+ this led to a ModuleNotFoundError on a clean install. This commit replaces the unconditional import with a version-guarded
dicksontsai
approved these changes
Aug 1, 2025
dicksontsai
reviewed
Aug 1, 2025
| @@ -1,5 +1,8 @@ | |||
| """Tests for Claude SDK type definitions.""" | |||
|
|
|||
| import sys | |||
There was a problem hiding this comment.
You don't need to import sys and pytest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an import issue with
typing_extensionsin the SDK.Problem:
typing_extensions.NotRequiredpyproject.toml,typing_extensionsis only installed for Python< 3.11typing.NotRequiredexists, but the package may not be installedModuleNotFoundErroron a clean install with Python 3.11+Solution:
typingon Python 3.11+