feat: add compressed graph in normal graph datacell #832
Conversation
Signed-off-by: Deming Chu <[email protected]>
…ompressed graph in deserial Signed-off-by: Deming Chu <[email protected]>
nedchu
requested review from
LHT129,
ShawnShawnYou,
inabao and
wxyucs
as code owners
Signed-off-by: Deming Chu <[email protected]>
Signed-off-by: Deming Chu <[email protected]>
| for (InnerIdType id = 0; id < this->max_capacity_; ++id) { | ||
| GraphDataCell::InsertNeighborsById(id, empty_ids); | ||
| } | ||
| } |
There was a problem hiding this comment.
When building a compressed graph from normal graph datacell, the prograph will go wrong if the neighbor set is not initialized by InsertNeighborsById (dirty data)
Init by InsertNeighborsById in the constructor and Resize.
nedchu
changed the title
Signed-off-by: Deming Chu <[email protected]>
Signed-off-by: Deming Chu <[email protected]>
Signed-off-by: Deming Chu <[email protected]>
| InnerIdType current = total_count_.load(); | ||
| while (current < id + 1 && !total_count_.compare_exchange_weak(current, id + 1)) { | ||
| } | ||
| } |
There was a problem hiding this comment.
IVF will be influenced by total_count_. Fix the segmentation fault
Signed-off-by: Deming Chu <[email protected]>
Signed-off-by: Deming Chu <[email protected]>
Signed-off-by: Deming Chu <[email protected]>
Signed-off-by: Deming Chu <[email protected]>
Signed-off-by: Deming Chu <[email protected]>
Signed-off-by: Xiangyu Wang <[email protected]>
Signed-off-by: Deming Chu <[email protected]>
Signed-off-by: Deming Chu <[email protected]>
Signed-off-by: Deming Chu <[email protected]>
Signed-off-by: Deming Chu <[email protected]>
Codecov ReportAttention: Patch coverage is ❌ Your patch check has failed because the patch coverage (76.47%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. @@ Coverage Diff @@
## main #832 +/- ##
==========================================
- Coverage 90.54% 90.13% -0.42%
==========================================
Files 222 218 -4
Lines 14972 14461 -511
==========================================
- Hits 13556 13034 -522
- Misses 1416 1427 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Signed-off-by: Deming Chu <[email protected]>
Signed-off-by: Deming Chu <[email protected]>
3 participants
closes: #831