-
-
Notifications
You must be signed in to change notification settings - Fork 787
docs(bubble): update messageRender type desc and fix typo #1048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
docs(bubble): update messageRender type desc and fix typo #1048
Conversation
📝 WalkthroughWalkthrough本次变更仅涉及 Bubble 组件文档的 TypeScript 类型定义示例修正与简化,包括 Changes
Sequence Diagram(s)(本次变更仅为文档类型示例修正,无需生成时序图。) Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Bundle ReportBundle size has no change ✅ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1048 +/- ##
=======================================
Coverage 92.54% 92.54%
=======================================
Files 69 69
Lines 1556 1556
Branches 418 418
=======================================
Hits 1440 1440
Misses 116 116 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
components/bubble/index.en-US.md
Outdated
@@ -56,7 +56,7 @@ Common props ref:[Common props](/docs/react/common-props) | |||
| typing | Show message with typing motion | boolean \| { step?: number, interval?: number } | false | | | |||
| variant | Style variant | `filled` \| `borderless` \| `outlined` \| `shadow` | `filled` | | | |||
| loadingRender | Customize loading content | () => ReactNode | - | | | |||
| messageRender | Customize display content | <ContentType extends [BubbleContentType](https://github.com/ant-design/x/blob/d3232c925a0dc61ad763c6664e16f07323ebca4a/components/bubble/interface.ts#L21) = string>(content?: ContentType) => ReactNode | - | | | |||
| messageRender | Customize display content | (content?: ContentType) => ReactNode | - | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ContentType 最好留一个链接,不然看不出来里面有啥。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
那我保留英文文档的链接,给中文文档补充下链接
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已更新
中文版模板 / Chinese template
🤔 This is a ...
🔗 Related Issues
💡 Background and Solution
中文文档中:为messageRender类型标注补充
ContentType
范性来源和链接(和英文文档保持一致)。Before:
After:
📝 Change Log
Summary by CodeRabbit