Skip to content

Conversation

hqwlkj
Copy link
Contributor

@hqwlkj hqwlkj commented Sep 22, 2025

因为这样设置了默认样式后,再通过 valueStyle 则无法进行修改。

image image

因为这样设置了默认样式后,再通过 valueStyle 则无法进行修改。
Copy link

Summary of Changes

Hello @hqwlkj, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

此拉取请求旨在解决 Statistic 组件中一个样式覆盖问题。通过移除对 Statistic 内容整数值硬编码的默认字体大小样式,确保了用户可以通过 valueStyle 属性正确地自定义字体大小,从而提高了组件的灵活性和可配置性。

Highlights

  • 移除默认字体大小样式: 移除了 Statistic 组件内容中整数值 (-value-int) 的默认字体大小样式 (fontSize: token.fontSizeHeading3)。
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Sep 22, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

本次变更移除了 Statistic 组件内容中针对整数部分 value-int 的默认字体大小样式。正如您在拉取请求描述中指出的,这个默认样式会阻止通过 valueStyle 属性进行样式覆盖,从而限制了组件的可定制性。移除这个特定的样式规则是一个正确的修复,它恢复了 valueStyle 属性的预期功能,使得组件更加灵活和易于使用。这是一个清晰且有效的改进。

@hqwlkj hqwlkj changed the title fix: 移除 Statistic content value int 的字体大小样式。 fix(statistic): 移除 Statistic content value int 的字体大小样式。 Sep 22, 2025
@leshalv
Copy link
Contributor

leshalv commented Sep 22, 2025

你这个改法应该是有问题的,为什么不考虑是用className进行更改

@hqwlkj
Copy link
Contributor Author

hqwlkj commented Sep 22, 2025

你这个改法应该是有问题的,为什么不考虑是用className进行更改

组件中就有 valueStyle 的支持, 开发者在 valueStyle 中设置了字体大小后,结果不生效;你认为合理吗?并且 antd 中的 Statistic 组件是可以通过 valueStyle 进行修改字体大小的 。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants