-
Notifications
You must be signed in to change notification settings - Fork 140
feat: prep7 - part 2
#4262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feat/main_prep7
Are you sure you want to change the base?
feat: prep7 - part 2
#4262
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
The I am removing the failing tests and EDIT: this command has been deprecated in R19.1 |
|
@clatapie The ability to pre/post process a explicit dynamics model for the ls-dyna solver was removed from mapdl in v19.1. So most of the commands that start with 'ED' should not exist anymore in mapdl....anyone wanting to use those could use PyDyna or PyMechanical (which supports ls-dyna solver). |
…contact``, ``edcrb``, ``edcurve``, ``edcadapt``, ``edcpu``, ``edcsc`` and ``edcts`` as removed
for more information, see https://pre-commit.ci
|
Thank you for your comment @mikerife! |
|
The # How it should render:
def tbft(self, oper, matid, option1, option2, option3, option4, option5, option6, option7, option10, **kwards):
# How it currently renders:
def tbft(self, **kwards):I am investigating it. |
|
This error enables me to catch a broader one: 5 functions (including The TBFT error was fixed with ansys/pyconverter-xml2py@ccbb8ca and the broader one with ansys/pyconverter-xml2py@73cab27 |
|
I confirm that the |
germa89
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After a quick look, it looks good to me.
However, I will add back the EDXXXX commands because PyMAPDL should be retrocompatible for as much versions as possible, that includes ANSYS 13.0 through the console interface.
Any person running any an Ansys version compatible with ED commands, should be able to run them using PyMAPDL.
Also please checks the
|
I am currently looking into a way to add the |
|
The PR is ready to be reviewed and merged on my side. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR continues the PyConverter-XML2Py integration to automate PyMAPDL command documentation, focusing on part 2 of the prep7 submodule. The changes involve migrating multiple command classes from the preproc package to the prep7 package with updated documentation formats and type hints.
Key Changes:
- Migrated 9 command classes (database, element_type, elements, explicit_dynamics, hard_points, keypoints, lines, materials, morphing) from
preproctoprep7 - Updated class inheritance in
Prep7CommandsandPreprocessorCommands - Modernized documentation with Sphinx directives and restructured RST files
Reviewed Changes
Copilot reviewed 32 out of 35 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/ansys/mapdl/core/commands.py |
Updated Prep7Commands to inherit from migrated classes, removed corresponding classes from PreprocessorCommands |
src/ansys/mapdl/core/_commands/preproc/*.py |
Deleted 9 command class files from preproc package |
src/ansys/mapdl/core/_commands/prep7/*.py |
Added 9 command class files to prep7 with updated type hints and documentation |
src/ansys/mapdl/core/_commands/preproc/__init__.py |
Removed imports for migrated classes |
src/ansys/mapdl/core/_commands/prep7/__init__.py |
Added imports for migrated classes |
doc/source/mapdl_commands/prep7/*.rst |
Updated documentation structure with new Sphinx references and class paths |
doc/changelog.d/4262.added.md |
Added changelog entry |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
germa89
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
This PR follows the PyConverter-XML2Py integration plan to automate the PyMAPDL_commands documentation.
The changes have been generated using pyconverter-xml2py and more specifically mapdl-cmd-conv.
This PR focus on the first part of the
prep7submodule integration.You can check the mapdl-cmd-conv documentation to have a look at the output of each methods.
Pinging @ansys/pymapdl-developers for visibility. Feel free to provide any feedback on the way the docstrings and the source code generation are handled.
Issue linked
This PR is meant to be merged within the feat/main_prep7 branch. The latter will gather all the parts of the submodule prior to be merged to the main branch.
Checklist
draftif it is not ready to be reviewed yet.feat: adding new MAPDL command)