-
Couldn't load subscription status.
- Fork 56
fix: 'wait_process_finished' in sessions. #4572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes the availability of wait_process_finished after session exit and ensures consistent post-exit behavior between solver and meshing sessions. Previously, wait_process_finished was not accessible after exiting a session, and there were inconsistencies in how dir() and attribute access behaved between the two session types.
Key Changes:
- Made
wait_process_finishedaccessible after session exit by updating__dir__and__getattr__/__getattribute__methods - Standardized post-exit behavior so only
is_activeandwait_process_finishedremain accessible in both session types - Added comprehensive tests to verify the new behavior
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/ansys/fluent/core/session.py | Updated __dir__ to include wait_process_finished in post-exit attribute list |
| src/ansys/fluent/core/session_meshing.py | Added _fluent_connection_backup and wait_process_finished to allowed attributes after session exit |
| src/ansys/fluent/core/session_solver.py | Added attribute access guard to restrict post-exit access similar to meshing session |
| tests/test_fluent_session.py | Added test cases to verify post-exit behavior for both meshing and solver sessions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
[1347769]
Context
Change Summary
Impact
'wait_process_finished' can be accessed after session exit and post exit only 'is_active' and 'wait_process_finished' can be accessed from a session, both in solver and meshing mode.