Skip to content

Conversation

@prmukherj
Copy link
Collaborator

[1347769]

Context

  1. 'wait_process_finished' was not available after session exit.
  2. Inconsistent behavior between solver and meshing session post exit.

Change Summary

  1. 'wait_process_finished' was made available after session exit.
  2. 'dir()' and attribute access amde consisten for both solver and meshing session post exit.

Impact

'wait_process_finished' can be accessed after session exit and post exit only 'is_active' and 'wait_process_finished' can be accessed from a session, both in solver and meshing mode.

@prmukherj prmukherj requested a review from mkundu1 as a code owner October 28, 2025 07:11
Copilot AI review requested due to automatic review settings October 28, 2025 07:11
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the availability of wait_process_finished after session exit and ensures consistent post-exit behavior between solver and meshing sessions. Previously, wait_process_finished was not accessible after exiting a session, and there were inconsistencies in how dir() and attribute access behaved between the two session types.

Key Changes:

  • Made wait_process_finished accessible after session exit by updating __dir__ and __getattr__/__getattribute__ methods
  • Standardized post-exit behavior so only is_active and wait_process_finished remain accessible in both session types
  • Added comprehensive tests to verify the new behavior

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
src/ansys/fluent/core/session.py Updated __dir__ to include wait_process_finished in post-exit attribute list
src/ansys/fluent/core/session_meshing.py Added _fluent_connection_backup and wait_process_finished to allowed attributes after session exit
src/ansys/fluent/core/session_solver.py Added attribute access guard to restrict post-exit access similar to meshing session
tests/test_fluent_session.py Added test cases to verify post-exit behavior for both meshing and solver sessions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions github-actions bot added the bug Issue, problem or error in PyFluent label Oct 28, 2025
Copilot AI review requested due to automatic review settings October 28, 2025 07:13
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings October 28, 2025 08:52
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings October 28, 2025 09:44
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue, problem or error in PyFluent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants