feat: Updates for the client side dm-api. #3748
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prmukherj
commented
Aug 18, 2025
prmukherj
commented
Aug 18, 2025
prmukherj
commented
Aug 18, 2025
prmukherj
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for a new client-side datamodel API called "meshing_workflow" to complement the existing "workflow" API. The changes enable access to meshing workflow functionality through a new meshing_workflow property across the meshing session classes.
- Introduces
meshing_workflowdatamodel API support for Fluent versions >=26.1 - Adds the new API to meshing session classes and type definitions
- Updates code generation infrastructure to handle the new workflow type
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_server_meshing_workflow.py | Comprehensive test suite for the new meshing workflow API functionality |
| tests/test_codegen.py | Updates test configuration to include meshing_workflow in static info mapping |
| src/ansys/fluent/core/session_pure_meshing.pyi | Type definitions for meshing_workflow property |
| src/ansys/fluent/core/session_pure_meshing.py | Implementation of meshing_workflow property in PureMeshing class |
| src/ansys/fluent/core/session_meshing.py | Implementation of meshing_workflow property in Meshing class |
| src/ansys/fluent/core/session_base_meshing.py | Base implementation and commented wrapper classes |
| src/ansys/fluent/core/services/datamodel_se.py | Cache handling modification for meshing_workflow |
| src/ansys/fluent/core/codegen/datamodelgen.py | Code generation support for meshing_workflow datamodel |
| src/ansys/fluent/core/codegen/init.py | Static info type enumeration addition |
| doc/datamodel_rstgen.py | Documentation generation support |
| doc/changelog.d/3748.added.md | Changelog entry |
| codegen/allapigen.py | API generation script updates |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
seanpearsonuk
approved these changes
Oct 9, 2025
hpohekar
approved these changes
Oct 9, 2025
mkundu1
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for a new client-side datamodel API called "meshing_workflow" to complement the existing "workflow" API. The changes enable access to meshing workflow functionality through a new meshing_workflow property across the meshing session classes.
Introduces meshing_workflow datamodel API support for Fluent versions >=26.1
Adds the new API to meshing session classes and type definitions
Updates code generation infrastructure to handle the new workflow type