Skip to content

Conversation

jacobrkerstetter
Copy link
Contributor

Description

  • remove _grpc_id from code base
  • designs.py has a few CommandsStub reference that still have this
  • rework problem area ids to abstract Int32Value object to _grpc layer

Issue linked

Related to #1817

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

remove EntityIdentifier from all except designs.py (needs small rework)
abstract Int32Value object to _grpc layer for problem area id's
@jacobrkerstetter jacobrkerstetter self-assigned this Oct 8, 2025
@jacobrkerstetter jacobrkerstetter requested a review from a team as a code owner October 8, 2025 20:33
Copy link

codecov bot commented Oct 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.27%. Comparing base (830c6d3) to head (25bd0d0).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2295      +/-   ##
==========================================
+ Coverage   95.23%   95.27%   +0.04%     
==========================================
  Files         169      169              
  Lines       11175    11150      -25     
==========================================
- Hits        10642    10623      -19     
+ Misses        533      527       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment - other than that, LGTM! I'll reapprove right after

Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jacobrkerstetter jacobrkerstetter enabled auto-merge (squash) October 9, 2025 12:52
@jacobrkerstetter jacobrkerstetter merged commit f78e1a6 into main Oct 9, 2025
46 checks passed
@jacobrkerstetter jacobrkerstetter deleted the chore/remove_grpc_ids branch October 9, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants