-
Notifications
You must be signed in to change notification settings - Fork 22
chore: remove grpc ids #2295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove grpc ids #2295
Conversation
remove EntityIdentifier from all except designs.py (needs small rework) abstract Int32Value object to _grpc layer for problem area id's
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2295 +/- ##
==========================================
+ Coverage 95.23% 95.27% +0.04%
==========================================
Files 169 169
Lines 11175 11150 -25
==========================================
- Hits 10642 10623 -19
+ Misses 533 527 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comment - other than that, LGTM! I'll reapprove right after
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Issue linked
Related to #1817
Checklist
feat: extrude circle to cylinder
)