Skip to content

Conversation

jacobrkerstetter
Copy link
Contributor

@jacobrkerstetter jacobrkerstetter commented Oct 8, 2025

Description

  • added "raw" tessellation methods that return dictionary of Polydata
  • raw tessellation data can be converted + used however user desires
  • speeds up bottleneck of creating PyVista MultiBlock's from tessellation

Issue linked

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@jacobrkerstetter jacobrkerstetter self-assigned this Oct 8, 2025
@jacobrkerstetter jacobrkerstetter requested a review from a team as a code owner October 8, 2025 14:13
@github-actions github-actions bot added the enhancement New features or code improvements label Oct 8, 2025
Copy link

codecov bot commented Oct 8, 2025

Codecov Report

❌ Patch coverage is 85.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.24%. Comparing base (1e85767) to head (68c6200).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ansys/geometry/core/designer/body.py 82.60% 4 Missing ⚠️
...c/ansys/geometry/core/_grpc/_services/v0/bodies.py 50.00% 1 Missing ⚠️
src/ansys/geometry/core/designer/design.py 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2294      +/-   ##
==========================================
- Coverage   95.27%   95.24%   -0.03%     
==========================================
  Files         169      169              
  Lines       11150    11185      +35     
==========================================
+ Hits        10623    10653      +30     
- Misses        527      532       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jacobrkerstetter jacobrkerstetter marked this pull request as draft October 8, 2025 14:36
@jacobrkerstetter jacobrkerstetter marked this pull request as ready for review October 8, 2025 20:31
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Further investigations required I believe

Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jacobrkerstetter jacobrkerstetter enabled auto-merge (squash) October 9, 2025 16:59
@jacobrkerstetter jacobrkerstetter merged commit d8b160c into main Oct 9, 2025
50 checks passed
@jacobrkerstetter jacobrkerstetter deleted the feat/design_tessellation_streaming branch October 9, 2025 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants