feat: Enable static event stream URLs with user-configurable UUIDs #1368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow users to provide custom UUIDs when creating event streams for consistent, static URLs. Users can also change UUIDs during updates for maximum flexibility.
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #1368 +/- ##
==========================================
+ Coverage 94.15% 94.16% +0.01%
==========================================
Files 335 336 +1
Lines 19533 19597 +64
==========================================
+ Hits 18391 18454 +63
- Misses 1142 1143 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
mkanoor
reviewed
Jul 30, 2025
| @@ -41,6 +42,22 @@ class EventStreamInSerializer(serializers.ModelSerializer): | |||
| ], | |||
| error_messages={"null": "EdaCredential is needed"}, | |||
| ) | |||
| uuid = serializers.UUIDField(required=False, allow_null=True) | |||
|
|
|||
| def validate_uuid(self, value): | |||
There was a problem hiding this comment.
@hsong-rh If we have unique=True and default=uuid4.uuid() set in the model do we still need this code?
There was a problem hiding this comment.
@mkanoor Use this validation function; we can handle exceptions better. Otherwise, we need to change in views to catch errors if they happen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow users to provide custom UUIDs when creating event streams for consistent, static URLs. Users can also change UUIDs during updates for maximum flexibility.
https://issues.redhat.com/browse/AAP-50564