Skip to content

Conversation

shatakshiiii
Copy link
Contributor

@shatakshiiii shatakshiiii commented Jul 2, 2025

@shatakshiiii
Copy link
Contributor Author

shatakshiiii commented Jul 9, 2025

Hi @ssbarnea @cidrblock, I need your inputs on this comment ansible/pattern-service#17 (comment).

ansible-lint's schemas are using the "examples" field for file glob patterns instead of actual JSON examples. And according to the JSON Schema specification the examples field should contain actual JSON data examples not file path patterns.

The ideal approach here would be to modify ansible-lint to use a different field name for file glob patterns and keep the "examples" field for actual JSON examples as per the JSON Schema specification. But this will require significant code changes in lint schema validation. WDYT, how should we proceed on this ?

Copy link
Member

@ssbarnea ssbarnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is incorrect, $id must be a link to a jSON file and not github webpage. Correct url is the one with raw: https://raw.githubusercontent.com/ansible/pattern-service/refs/heads/main/specifications/pattern_specification.json

@ssbarnea
Copy link
Member

Put this on hold till we have patterns team publish their schema. We are blocked by them.

@shatakshiiii shatakshiiii changed the title Update pattern schema from URL pointing to pattern-service repo Update pattern schema URL to point to pattern-service repo Jul 11, 2025
@shatakshiiii shatakshiiii changed the title Update pattern schema URL to point to pattern-service repo Update pattern schema URL to point pattern-service repo Jul 11, 2025
Copy link

github-actions bot commented Sep 4, 2025

Label error. Requires exactly 1 of: breaking, build, chore, ci, docs, feat, fix, perf, refactor, style, test. Found: . Follow https://www.conventionalcommits.org to get auto-labeling to work correctly.

@shatakshiiii
Copy link
Contributor Author

Completed in an another PR.

@github-project-automation github-project-automation bot moved this from In Progress to Done in 🧰 devtools project board Sep 11, 2025
@shatakshiiii shatakshiiii deleted the pattern_schema_update branch September 11, 2025 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants