docs: migrate to signals and takeUntilDestroyed #32033
Open
+48
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MeAkib
requested review from
andrewseguin and
wagnermaciel
and removed request for
a team
|
Looks like there are lint failures. |
- Replace lifecycle hooks with constructor initialization - Convert properties to signals (items, section, _categoryListSummary) - Use takeUntilDestroyed() for automatic cleanup - Replace async/await with switchMap to prevent race conditions - Remove manual subscription management Benefits: Better performance, automatic cleanup, safer async handling
MeAkib
force-pushed
the
refactor/docs-category-list
branch
from
24373e1 to
238d861
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benefits: Better performance, automatic cleanup, safer async handling