Add Python3 pre-commit config checks with pylint and mypy #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates:
pre-commit
runspylint
(uses pyenchant)tests/python/conftest.py
: Add a pytest fixture for unit-teststests/python/test_parse_test_instance_string.py
: Add an initial unit test for xtf-runner using the pytest fixture.Updated commit message:
This PR is ment as an example, but it may also be taken as-is or used as starting point for more:
Add Python3 pre-commit config checks with pylint and mypy:
.pre-commit-config.yaml
for https://github.com/pre-commit with a quick checks and automatic fixups:.github/workflows/build.yml
.pylintrc
to also support passing the latest Python3 pylint checks while toleratingpylint
config settings for old Python2-only pylint versions.build/mkinfo.py
.xtf-runner
:type: ignore[no-redef]
to for Python3 mypy and add a Python2-compatible type comment formypy
.pylint: disable
comments to locations where appropriateline-too-long
warning while resolving ano-else-return
pylint warning.