Skip to content

Remove TV prefix from Lazy* scrollable components after migration to common foundation #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove TV prefix from Lazy* scrollable components after migration to common foundation #204

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions JetStreamCompose/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,11 @@ real-world architecture.
* Showcases
* TabRow
* Carousel
* TvLazyRow
* LazyRow
* ImmersiveList
* TvLazyColumn
* LazyColumn
* Tv Material Surface
* TvVerticalGrid
* VerticalGrid
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The PR aims to reflect the migration to androidx.compose.foundation.lazy and mentions "Lazy* scrollable components". While VerticalGrid removes the Tv prefix, the actual component in androidx.compose.foundation.lazy.grid is LazyVerticalGrid.

For consistency with LazyRow and LazyColumn in this list, and to more accurately reflect the component name from the foundation library (as seen in FilteredMoviesGrid.kt and CategoryMovieListScreen.kt), would it be clearer to use LazyVerticalGrid here?

Suggested change
* VerticalGrid
* LazyVerticalGrid

* Tv Material Cards
* Buttons
* Icon
Expand Down