Skip to content

Conversation

MGaetan89
Copy link

@MGaetan89 MGaetan89 commented Aug 27, 2025

The following projects were missing from the projects.conf file, so they were not updated when running update_versions.sh:

  • runner/AndroidTestOrchestratorWithTestCoverageSample
  • unit/BasicSample
  • unit/BasicSample-kotlinApp
  • unit/BasicUnitAndroidTest

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @MGaetan89, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an oversight where several sample projects were not being updated by the automated versioning script due to their absence from 'projects.conf'. The core change involves adding these missing project paths to the configuration file. Concurrently, the PR updates the Android SDK versions, Android Gradle Plugin versions, and various AndroidX and testing library dependencies within these newly included projects to bring them up to current standards, ensuring their compatibility and maintainability.

Highlights

  • Inclusion of Missing Projects: This pull request adds several sample project paths to the 'projects.conf' file. This ensures that these projects, which were previously missing, will now be correctly included and updated when the 'update_versions.sh' script is executed.
  • Android SDK Version Updates: Multiple 'build.gradle' files across the newly included projects have been updated to target Android API Level 34. This includes bumping 'compileSdk' and 'targetSdkVersion' to 34, and 'minSdkVersion' to 21, aligning these projects with more recent Android development standards.
  • Dependency and Tooling Version Bumps: The Android Gradle Plugin (AGP) version has been consistently updated to '8.5.0' in relevant 'build.gradle' files. Additionally, various AndroidX and testing library dependencies, such as 'androidxAnnotationVersion', 'guavaVersion', 'coreVersion', 'extJUnitVersion', 'runnerVersion', 'rulesVersion', 'orchestratorVersion', and 'espressoVersion', have been bumped to their latest stable or alpha versions.
  • Kotlin Version Update: The Kotlin version used in 'unit/BasicSample-kotlinApp' has been updated from '1.3.61' to '1.9.22', ensuring the Kotlin-based sample project uses a more recent and feature-rich version of the language.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds several projects that were missing from projects.conf and updates their dependencies and SDK versions. The changes are mostly correct, but I found one critical issue: a project has been duplicated in projects.conf. Please see my comment for details on how to fix it.

The following projects were missing from the `projects.conf` file, so they were not updated when running `update_versions.sh`:
- `runner/AndroidTestOrchestratorWithTestCoverageSample`
- `unit/BasicSample`
- `unit/BasicSample-kotlinApp`
- `unit/BasicUnitAndroidTest`
@MGaetan89 MGaetan89 force-pushed the add-missing-projects branch from 3b70e30 to b2678b5 Compare August 27, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant