-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Update to Robolectric 4.16 #535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
I've updated `update_versions.sh` to update every project to Robolectric 4.16. `unit/BasicNativeAndroidTest` had outdated dependencies, which have been updated by running this script.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @MGaetan89, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on updating the Robolectric testing framework to version 4.16 across various Android projects. Additionally, it addresses and resolves outdated dependencies within the unit/BasicNativeAndroidTest
project by updating its compileSdk
version and several other related library versions to their latest stable releases.
Highlights
- Robolectric Version Update: Upgraded the Robolectric testing framework to version 4.16 in multiple build.gradle files across various UI Espresso samples.
- Dependency Updates for BasicNativeAndroidTest Project: Updated the compileSdk to 34 and refreshed several testing and build-related dependencies (e.g., Android Gradle Plugin, Kotlin, Espresso, JUnit) within the unit/BasicNativeAndroidTest project to resolve outdated dependencies.
- Script Synchronization: The update_versions.sh script was modified to reflect the new Robolectric version and to correct minor comment formatting.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates Robolectric to version 4.16 across multiple projects by modifying the update_versions.sh
script. It also includes updates to several other dependencies for the unit/BasicNativeAndroidTest
project, moving them from alpha releases to stable versions. The changes are generally good, but I've identified an issue where the update_versions.sh
script fails to update targetSdk
and minSdk
in unit/BasicNativeAndroidTest/app/build.gradle
due to incorrect property names in the script, leading to a mismatch with the updated compileSdk
.
…Screenshot`, and `unit/BasicNativeAndroidTest`
I've updated
update_versions.sh
to update every project to Robolectric 4.16.unit/BasicNativeAndroidTest
had outdated dependencies, which have been updated by running this script.Note:
unit/BasicNativeAndroidTest
was using thetargetSdk
property instead oftargetSdkVersion
. I've changed it so runningupdate_versions.sh
also changes it in that project.Note2: the same has been done for
minSdk
/minSDKVersion
inui/espresso/ScreenshotSample
,ui/PreviewScreenshot
, andunit/BasicNativeAndroidTest
.Release notes: