Skip to content

Conversation

MGaetan89
Copy link

@MGaetan89 MGaetan89 commented Aug 27, 2025

This commit removes explicit @TextLayoutMode and @LooperMode declarations, since they use the default value.

LooperMode is set to PAUSED in Robolectric 4.13: https://github.com/robolectric/robolectric/blob/79bc3034b38b94ed8b4317b666edb42f093358cd/robolectric/src/main/java/org/robolectric/plugins/LooperModeConfigurer.java#L17
TextLayoutMode is set to REALISTIC in Robolectric 4.13: https://github.com/robolectric/robolectric/blob/79bc3034b38b94ed8b4317b666edb42f093358cd/robolectric/src/main/java/org/robolectric/plugins/TextLayoutModeConfigurer.java#L17

Note: TextLayoutMode has been deprecated in Robolectric 4.16.

This commit removes explicit `@TextLayoutMode` and `@LooperMode` declarations, since they use the default value.
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @MGaetan89, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on simplifying Android test configurations by removing redundant Robolectric annotations and their associated dependencies. With Robolectric version 4.13, the @TextLayoutMode(REALISTIC) and @LooperMode(PAUSED) settings are now the default behavior. Consequently, this change cleans up the codebase by eliminating unnecessary explicit declarations and build file entries, leading to more concise and maintainable test code without altering the functional behavior of the tests.

Highlights

  • Annotation Removal: The pull request removes explicit @TextLayoutMode and @LooperMode annotations from various test files, such as HintMatchersTest.java and DialerActivityTest.java.
  • Dependency Cleanup: The org.robolectric:annotations dependency has been removed from app/build.gradle files in CustomMatcherSample, FragmentScenarioSample, and IntentsBasicSample modules.
  • Test Configuration Simplification: These changes are possible because Robolectric 4.13 now sets LooperMode to PAUSED and TextLayoutMode to REALISTIC by default, making the explicit declarations redundant.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes explicit @TextLayoutMode and @LooperMode annotations, which are now default values in Robolectric 4.13. The changes correctly remove the annotations, their associated imports, and the robolectric:annotations dependency from Gradle files. This is a good cleanup that improves code maintainability by removing redundant configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant