Skip to content

Conversation

devbridie
Copy link
Member

  • The <uses-feature android:name="android.software.xr.api.spatial" android:required="false" /> tag allows for apps to identify to have themselves as having XR-differentiated features, which Androidify now has!
  • Rewrote MainPanelWorkaround to prevent a quick flash of the MainPanel in the spatial view

Copy link
Contributor

Summary of Changes

Hello @devbridie, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces several fixes aimed at enhancing the Extended Reality (XR) experience within the Androidify application. The primary goal is to eliminate a visual glitch where a main panel would briefly flash in spatial views, improving the overall smoothness and polish of the immersive interface. Additionally, it formally declares the app's capability to leverage XR spatial APIs, clarifying its compatibility with XR environments without imposing a hard dependency.

Highlights

  • XR Feature Declaration: Added a declaration in the AndroidManifest.xml to indicate that the application can utilize XR spatial features, but these features are not strictly required for the app to function.
  • MainPanelWorkaround Refactor: The MainPanelWorkaround composable was rewritten to use DisposableEffect instead of LaunchedEffect with a continuous loop. This change ensures the main panel is hidden reliably upon the composable's disposal, addressing a race condition that caused a quick flash of the panel in spatial views.
  • Workaround Placement Adjustment: The MainPanelWorkaround() call was relocated in several spatial screens (EditScreenSpatial, LoadingScreenSpatial, AboutScreenSpatial, HomeScreenSpatial, ResultsScreenSpatial) to a higher level in their respective composable hierarchies. This adjustment ensures the workaround is applied correctly in the composition, preventing the unwanted panel flash.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a couple of nice fixups for XR functionality. It correctly declares the optional usage of the spatial XR API in the AndroidManifest.xml. The main improvement is the refactoring of MainPanelWorkaround to use DisposableEffect instead of an inefficient polling loop. This is a much better approach for handling cleanup logic in Compose. The call sites for this workaround have been updated accordingly to ensure it functions correctly with the new implementation.

I have one suggestion to make the MainPanelWorkaround even more robust by keying the DisposableEffect to the session.

Base automatically changed from feature/xr/about-screen to main September 26, 2025 09:17
devbridie and others added 2 commits September 26, 2025 11:18
…nPanelWorkaround.kt

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@devbridie devbridie merged commit 1d1977c into main Sep 26, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants