-
Notifications
You must be signed in to change notification settings - Fork 204
Miscellaneous XR fixups #151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @devbridie, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces several fixes aimed at enhancing the Extended Reality (XR) experience within the Androidify application. The primary goal is to eliminate a visual glitch where a main panel would briefly flash in spatial views, improving the overall smoothness and polish of the immersive interface. Additionally, it formally declares the app's capability to leverage XR spatial APIs, clarifying its compatibility with XR environments without imposing a hard dependency. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a couple of nice fixups for XR functionality. It correctly declares the optional usage of the spatial XR API in the AndroidManifest.xml
. The main improvement is the refactoring of MainPanelWorkaround
to use DisposableEffect
instead of an inefficient polling loop. This is a much better approach for handling cleanup logic in Compose. The call sites for this workaround have been updated accordingly to ensure it functions correctly with the new implementation.
I have one suggestion to make the MainPanelWorkaround
even more robust by keying the DisposableEffect
to the session.
core/xr/src/main/java/com/android/developers/androidify/xr/MainPanelWorkaround.kt
Outdated
Show resolved
Hide resolved
…nPanelWorkaround.kt Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
<uses-feature android:name="android.software.xr.api.spatial" android:required="false" />
tag allows for apps to identify to have themselves as having XR-differentiated features, which Androidify now has!MainPanelWorkaround
to prevent a quick flash of the MainPanel in the spatial view