-
Notifications
You must be signed in to change notification settings - Fork 202
Add a Spatial layout for the Camera screen #144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This allows the Spatial layout to maintain an arbitrary aspect ratio without any cropping.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @devbridie, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a significant enhancement to the Camera screen by implementing a new spatial layout tailored for XR (Extended Reality) environments. The core change involves a flexible preview panel that automatically adjusts its aspect ratio to align with the device's camera output, providing a more immersive and adaptive user experience. This update integrates new XR-specific UI components and logic, ensuring the camera interface is optimized for spatial computing contexts.
Highlights
- Spatial Layout Integration: Introduced a new spatial layout (
CameraLayoutSpatial
) for the Camera screen, leveragingandroidx.xr.compose
components to enable XR-specific UI. - Dynamic Aspect Ratio: The camera preview panel in the spatial layout now dynamically resizes to match the device-dependent camera aspect ratio, ensuring an optimal display.
- XR Capability Detection: The
CameraLayout
conditionally renders the spatial layout based on whether XR is enabled and spatial UI capabilities are present, allowing for adaptive UI. - Dependency Updates: Added
androidx.xr.compose
andprojects.core.xr
dependencies to thebuild.gradle.kts
file to support the new spatial computing features. - ViewModel Enhancements:
CameraViewModel
now initializes the XR enabled state fromConfigProvider
and tracks the camera's surface aspect ratio, which is crucial for the spatial layout.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands on the current page.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a spatial layout for the camera screen, which is displayed when running on a device with XR capabilities. The implementation involves adding new dependencies, creating a CameraLayoutSpatial
composable, and updating the view model and existing composables to handle the new xrEnabled
and surfaceAspectRatio
states. The changes are logical and well-structured. I have a couple of suggestions: one to fix a potential rendering issue in the new spatial layout and another to clean up some dead code for better maintainability. See my detailed comments below.
This PR adds a Spatial layout for the Camera screen.
In the Spatial layout, the panel the preview is displayed on is able to resize itself to the aspect ratio of the device-dependent camera aspect ratio.