Skip to content

[WIP] drop julia < 0.5 and prepare for 0.6 #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

CarloLucibello
Copy link
Collaborator

@CarloLucibello CarloLucibello commented Jan 30, 2017

trying to address #23

@coveralls
Copy link

coveralls commented Jan 30, 2017

Coverage Status

Coverage decreased (-3.5%) to 84.371% when pulling 22dbcbc on CarloLucibello:j06 into a0c0da6 on andrewcooke:master.

@coveralls
Copy link

coveralls commented Jan 30, 2017

Coverage Status

Coverage decreased (-4.5%) to 83.38% when pulling e90a9c9 on CarloLucibello:j06 into a0c0da6 on andrewcooke:master.

@CarloLucibello CarloLucibello changed the title add precompile and drop julia <0.5 to easy the transitions towards 0.6 [WIP] drop julia < 0.5 and prepare for 0.6 Mar 9, 2017
@CarloLucibello
Copy link
Collaborator Author

@andrewcooke @sbromberger can someone continue from here or give me a hand?

On julia 0.6 there are still a lot of tests not passing, and some passing but giving weird results.

Also due to the new Channel sintax this is not working on 0.5 right now and I'm not sure 0.5 compatibility can be kept. This is a minor problem, maybe it is just better to drop 0.5 to have the most maintanable thing we can have

@sbromberger
Copy link
Contributor

Yeah, we're seeing similar issues in LG right now. Our solution is to move 0.6 compatibility into its own branch that will not be backwards-compatible with 0.5.

@CarloLucibello
Copy link
Collaborator Author

@andrewcooke if you find some spare time please continue the update work from here. There are a few issues left that I couldn't manage to solve, shouldn't take much though.

Bye
Carlo

This was referenced Nov 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants