[pull] master from elastic:master #1961
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
) ensure transform has done something before stop gets called with wait_for_checkpoint=true fixes #79621
There is no need to use stopRandomNode/namePredicate combination to stop a node by its name.
Our docs currently recommend PBKDF2 as a cache hasher in FIPS mode. However, the performance overhead of PBKDF2 is prohibitive; ssha256 is a more appropriate choice for in-memory credential hashing. This PR updates the docs to reflect this. See #86740 for more context.
Making this a little smaller so it inlines more often and more importantly avoid getting the current field name redundantly before entering the loop which is not free when the parser is a `DotExpandingXContentParser`. This change gives a significant boost to `BeatsMapperBenchmark.benchmarkParseKeywordFields`. Results below are pretty stable, running with a large number of iterations. before: ``` Result "org.elasticsearch.benchmark.index.mapper.BeatsMapperBenchmark.benchmarkParseKeywordFields": 9039.270 ±(99.9%) 28.001 ns/op [Average] (min, avg, max) = (9008.778, 9039.270, 9062.246), stdev = 18.521 CI (99.9%): [9011.269, 9067.271] (assumes normal distribution) ``` after: ``` Result "org.elasticsearch.benchmark.index.mapper.BeatsMapperBenchmark.benchmarkParseKeywordFields": 8645.649 ±(99.9%) 53.677 ns/op [Average] (min, avg, max) = (8568.319, 8645.649, 8688.210), stdev = 35.504 CI (99.9%): [8591.972, 8699.327] (assumes normal distribution) ```
Improve RollupShardIndexer by reducing the calls to BytesRef.deepCopyOf(tsid)
Today each time there's shards to snapshot we enqueue a lambda which captures the current `SnapshotsInProgress$Entry`. This is a pretty heavyweight object, possibly several MB in size, most of which is not necessary to capture, and with concurrent snapshots across thousands of shards we may enqueue many hundreds of slightly different such objects. With this commit we compute a more efficient representation of the work to be done by each task in the queue instead. Relates #77466
Co-authored-by: Gordon Brown <[email protected]>
This PR adds a new `knn` option to the `_search` API to support ANN search. It's powered by the same Lucene ANN capabilities as the old `_knn_search` endpoint. The `knn` option can be combined with other search features like queries and aggregations. Addresses #87625
ClosePointInTimeRequest#validate should return a validation error for an invalid pit_id, but it throws an IAE instead. This mistake prevents close_point_in_time tasks of requests with empty pit_id from being removed.
If there is no shard failure we would like to use a generic Internal Server Error other than a Service Unavailable. Moreover, if the cause is known we use a status code that reflects the cause.
* Convert disk watermarks to RelativeByteSizeValues Similar to the existing watermark setting for the frozen tier. Pre-requisite for PR 88639 that plans to introduce max headroom settings for the disk watermarks, similar to the frozen tier max headroom setting. * Add changelog * Revert 20gb to 20GB * Make formatNoTrailingZerosPercent non static * ByteSizeValue.MINUS_ONE * Remove getMinimumTotalSizeForBelowWatermark * Remove comment * Fix minor stuff * Make parsing of RelativeByteSizeValue faster Mimicks older definitelyNotPercentage function * Remove Locale from Strings.format * More MINUS_ONE
The KnnSearchBuilder constructor validates that k is always less than num_cands. But the mutateInstance method could increase k past num_cands. Now we construct the instance with a larger num_cands to make sure this never happens. Closes #88734.
…found (#88023) Co-authored-by: Niels Dewulf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )