Skip to content

CV3-71 receive notifications via bouquet #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: v2
Choose a base branch
from

Conversation

manzif
Copy link

@manzif manzif commented Dec 23, 2019

Description

A bouquet should be able to receive notifications and pass them on to whichever subscriber is listening for them.

How can This be tested

  • Clone the repo: git clone https://github.com/andela/mrm_push.git
  • Setup project according to Readme.md
  • checkout to branch story/CV3-70-implement-delete-bouquet
  • to delete a bouquet, hit the endpoint http://127.0.0.1:5000/v2/bouquets?bouquet_id=?

Type of change

Please select the relevant option

  • Bugfix(a non-breaking change which fixes an issue)
  • New feature(a non-breaking change which adds functionality)
  • Breaking change(fix of a feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have linted my code prior to submission
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

JIRA

CV3-71

@manzif manzif changed the title bla CV3-71 receive notifications via bouquet Dec 23, 2019
@manzif manzif force-pushed the story/CV3-71-receive-notifications-via-bouquet branch 3 times, most recently from 150b7aa to 15ed24c Compare December 23, 2019 13:51
@manzif manzif added the WIP label Dec 23, 2019
@manzif manzif force-pushed the story/CV3-71-receive-notifications-via-bouquet branch 5 times, most recently from 28f8ba4 to 560e25a Compare December 30, 2019 13:46
@manzif manzif force-pushed the story/CV3-71-receive-notifications-via-bouquet branch 6 times, most recently from 01b7ae4 to 9efdf93 Compare December 31, 2019 09:34
  - receive notifications from google
  - pass notifications on to subscribers that are listening.
@manzif manzif force-pushed the story/CV3-71-receive-notifications-via-bouquet branch from 9efdf93 to 9968ef9 Compare December 31, 2019 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant