Skip to content

CV3-86 Implement functionality that allows Staging to receive Push Notifications #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

CV3-86 Implement functionality that allows Staging to receive Push Notifications #35

wants to merge 1 commit into from

Conversation

kodek-sleuth
Copy link

Description

This pull request implements functionality that enables addition of a bouquet.

How can This be tested

  • Clone the repo: git clone https://github.com/andela/mrm_push.git
  • Setup project according to Readme.md
  • checkout to branch `story/CV3-allow-push-notifications-staging

Type of change

Please select the relevant option

  • Bugfix(a non-breaking change which fixes an issue)
  • New feature(a non-breaking change which adds functionality)
  • Breaking change(fix of a feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have linted my code prior to submission
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes

JIRA

CV3-86

@kodek-sleuth kodek-sleuth force-pushed the story/CV3-86-allow-push-notifications-on-staging branch from 9ac020e to bea532e Compare December 6, 2019 17:14
@kodek-sleuth
CV3-86-story(allow-push-notifications-staging): Implement functionali…
4ecf9e5 
…ty that allows Staging to receive Push Notifications

 -  Implement functionality that allows Staging to receive Push Notifications

[Delivers CV3-86]
@kodek-sleuth kodek-sleuth force-pushed the story/CV3-86-allow-push-notifications-on-staging branch from bea532e to 4ecf9e5 Compare December 6, 2019 17:16
Emile-Nsengimana
Emile-Nsengimana suggested changes Dec 9, 2019
View reviewed changes
Copy link

@Emile-Nsengimana Emile-Nsengimana left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job @kodek-sleuth. But it will be good if you follow the engineering-playbook while naming your PR (link)

@kodek-sleuth kodek-sleuth changed the title CV3-86-story(allow-push-notifications-staging): Implement functionality that allows Staging to receive Push Notifications CV3-86 Implement functionality that allows Staging to receive Push Notifications Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Emile-Nsengimana Emile-Nsengimana Emile-Nsengimana approved these changes

@manzif manzif manzif approved these changes

@joshuaocero joshuaocero Awaiting requested review from joshuaocero

Assignees
No one assigned
Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kodek-sleuth @Emile-Nsengimana @manzif