Skip to content

Introducing bugsnag to converge backend #519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Introducing bugsnag to converge backend #519

wants to merge 1 commit into from

Conversation

shaluchandwani
Copy link
Contributor

@shaluchandwani shaluchandwani commented Dec 16, 2019 •
edited
Loading

Description

In order to help with troubleshooting issues on staging and productions, we would like to use Bugsnag to log any issues on the environments. Bugsnag is already configured, we just need to use it. In order to improve performance, use Celery to handle tasks so logging is non-blocking.

Type of change

Please select the relevant option

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Others (cosmetics, styling, improvements)
  • This change requires a documentation update

How Has This Been Tested?

  • Unit
  • Integration
  • End-to-end

How to Test

  • Check the code climate report to see if any file from the fixtures folder violates the file-line-limit
  • create an account on bugsnag and put the secret key in .env, then fire any request which creates the error. You should receive an error notification in the bugsnag dashboard and on GraphQl both.
  • Follow the instructions on the readme.md file on running tests. Check to see if tests run successfully

Checklist

  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have linted my code prior to submission
  • Existing unit tests pass locally with my changes
  • Implementation works according to expectations

JIRA

CV3-92

@shaluchandwani shaluchandwani force-pushed the story/CV3-92-introducing-bugsnag-to-converge-backend branch 6 times, most recently from 734ea3d to 0fbcd0e Compare December 19, 2019 14:53
@shaluchandwani
CV3-92-story(bugsnagconfigure):introducing bugsnag to converge backend
0b84f48 
- write logic to run functionality and log errors in dashboard
- verify that errors are not coming on running tests

[Delivers CV3-92]
@shaluchandwani shaluchandwani force-pushed the story/CV3-92-introducing-bugsnag-to-converge-backend branch from 0fbcd0e to 0b84f48 Compare December 19, 2019 15:35
@shaluchandwani shaluchandwani added TTL Review Technical Team Lead Review and removed peer review labels Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adafia adafia adafia approved these changes

@mifeille mifeille mifeille approved these changes

@joshuaocero joshuaocero Awaiting requested review from joshuaocero

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
TTL Review Technical Team Lead Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shaluchandwani @adafia @mifeille