Skip to content

CON-72 Setup for Admin notifications feature #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

CON-72 Setup for Admin notifications feature #443

wants to merge 9 commits into from

Conversation

Arusey
Copy link
Contributor

@Arusey Arusey commented Jun 22, 2019 •
edited
Loading

Description

This Pull request allows an administrator for the converge web app to receive notifications whenever a device has not been seen in a while.

Type of Change

  • New feature (non-breaking change which adds functionality

How has this been tested

  • Unit tests
  • Integration tests

Checklist

  • My code follows the style guidelines of this project
  • I have linted my code prior to submission
  • My changes generate no new warnings
  • Existing unit tests pass locally with my changes
  • Implementation works according to expectations

JIRA

CON-72

@codinger41
CON-72-story(admin-notifications): setup admin notifications
0820432 
- setup folder structure for implementing notifications structure
- implement notification when admin has not been seen in a while

[Delivers CON-72]
@Arusey Arusey added the wip label Jun 22, 2019
@Arusey Arusey force-pushed the story/CON-72-setup-notifications-admin branch 8 times, most recently from c4c3d9c to 9bb532b Compare June 25, 2019 09:39
codinger41 and others added 3 commits June 25, 2019 13:49
@codinger41
feat(notifications): setup notific ations
1a6ce5e 
- add new model for adminnotifications

[Delivers CON-71]
@codinger41
feat(notifications): setup notific ations
599bd44 
- add new model for adminnotifications

[Delivers CON-71]
CON-72-story(notifications): admin receives notification when device …
8980de4 
…is not seen in a while

- setup queue manager for when notifications are sent
- implement notifications when device is not seen in a while

[Delivers CON-72]
@Arusey Arusey force-pushed the story/CON-72-setup-notifications-admin branch 2 times, most recently from 8980de4 to cb8c297 Compare June 26, 2019 10:46
codinger41 and others added 2 commits June 27, 2019 09:08
@codinger41
feat(notifications): setup notific ations
c23c551 
- add new model for adminnotifications

[Delivers CON-71]
CON-72-story(notifications): admin receives notification when device …
1bb2408 
…is not seen in a while

- setup queue manager for when notifications are sent
- implement notifications when device is not seen in a while

[Delivers CON-72]
@Arusey Arusey force-pushed the story/CON-72-setup-notifications-admin branch from cb8c297 to 1bb2408 Compare June 27, 2019 06:12
@Arusey Arusey changed the title CON-72 Notify Admin when Device is not seen in a While CON-72 Setup for Admin notifications feature Jun 27, 2019
@codinger41
CON-72-story(admin-notifications): setup admin notifications
e5de19a 
- setup folder structure for implementing notifications structure
- implement notification when admin has not been seen in a while

[Delivers CON-72]
@Arusey Arusey force-pushed the story/CON-72-setup-notifications-admin branch 6 times, most recently from 9e7c01d to 10c7012 Compare July 1, 2019 06:20
@codinger41
feat(notifications): send notifications to admins when an event is au…
eb9b082 
…tocancelled

- add new model for adminnotifications
- setup socketio for real time notifications
- add query to get all notifications
- add mutation to change the status of notification

[Delivers CON-71]
@codinger41 codinger41 force-pushed the story/CON-72-setup-notifications-admin branch 3 times, most recently from 7f0a249 to 421f621 Compare July 9, 2019 13:03
@codinger41 codinger41 force-pushed the story/CON-72-setup-notifications-admin branch from 421f621 to eb87176 Compare July 9, 2019 13:15
@Arusey Arusey removed the wip label Jul 10, 2019
@codinger41 codinger41 force-pushed the story/CON-72-setup-notifications-admin branch from eb87176 to 6c3a1ff Compare July 10, 2019 10:47
@Arusey Arusey force-pushed the story/CON-72-setup-notifications-admin branch from 6c3a1ff to bb0d9a6 Compare July 10, 2019 12:12
@codinger41 codinger41 force-pushed the story/CON-72-setup-notifications-admin branch 6 times, most recently from 670dfcb to 9647f35 Compare July 15, 2019 13:06
@codinger41 codinger41 force-pushed the story/CON-72-setup-notifications-admin branch from 9647f35 to 9ccc092 Compare July 15, 2019 13:57
@Arusey Arusey added the wip label Jul 16, 2019
vic3king
vic3king suggested changes Jul 25, 2019
View reviewed changes
Copy link
Contributor

@vic3king vic3king left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @Arusey If this PR is still up for review could you please update the description on how to test it out? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vic3king vic3king vic3king requested changes

@codinger41 codinger41 Awaiting requested review from codinger41

@joshuaocero joshuaocero Awaiting requested review from joshuaocero

@koitoror koitoror Awaiting requested review from koitoror

@mnswaleh mnswaleh Awaiting requested review from mnswaleh

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
wip
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Arusey @vic3king @codinger41