get severity for GHSAs missing it #599
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes secDB using distros include information that a given package version fixed a GHSA. This causes a GHSA match with no severity to be emitted by grype.
In the case that a provider other than the GitHub provider emits a vulnerability with GHSA ID, copy the severity from GitHub.
This is related to anchore/grype#2691 but is only a partial fix. Sometimes SecDB using distros will publish that they have fixed an unreviewed GHSA. This change does not address that situation, because unreviewed GHSAs are not present in the data set, and so this will not be able to copy a severity for one. (Also, GitHub have likely not assigned a severity to an unreviewed GHSA anyway.)
A better approach might be to make the Wolfi vunnel provider know about the GitHub data, and have it fetch the alias field from the GHSA, and put the severity from the CVE that's an alias of the GHSA in its output, see anchore/grype#2691 (comment)